Issue 5556043: code review 5556043: test: match gccgo error messages for bug345

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5556043: code review 5556043: test: match gccgo error messages for bug345 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by iant

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

test: match gccgo error messages for bug345 bug345.dir/main.go:25:18: error: argument 1 has incompatible type (need explicit conversion; missing method ‘Write’) bug345.dir/main.go:27:8: error: argument 1 has incompatible type

Patch Set 1 #

Patch Set 2 : diff -r d22a02a28e5d https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	test/fixedbugs/bug345.dir/main.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2012-01-17 23:45:56 UTC) #1

iant

13 years, 3 months ago (2012-01-18 02:00:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6669b685aa14 ***

test: match gccgo error messages for bug345

bug345.dir/main.go:25:18: error: argument 1 has incompatible type (need explicit
conversion; missing method ‘Write’)
bug345.dir/main.go:27:8: error: argument 1 has incompatible type

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5556043

Expand All Messages | Collapse All Messages