Issue 5553044: code review 5553044: fmt: fix Malloc test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5553044: code review 5553044: fmt: fix Malloc test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by r

Modified:
13 years, 3 months ago

Reviewers:
dave

CC:
golang-dev, gri

Visibility:
Public.

Description

fmt: fix Malloc test We need to avoid allocating an extra word for the interface value passing the floating-point value as an interface{}. It's easy. Fixes issue 2722.

Patch Set 1 #

Patch Set 2 : diff -r f891d14d88e2 https://code.google.com/p/go #

Patch Set 3 : diff -r f891d14d88e2 https://code.google.com/p/go #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	src/pkg/fmt/fmt_test.go	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

13 years, 3 months ago (2012-01-17 23:35:19 UTC) #1

*** Submitted as b0084fd76ac7 *** fmt: fix Malloc test We need to avoid allocating an ...

13 years, 3 months ago (2012-01-17 23:42:05 UTC) #3

dave_cheney.net

13 years, 3 months ago (2012-01-18 00:16:06 UTC) #4

I'm pretty sure that doing %g on float32s only requires one allow on all
platforms. 

Sent from my iPhone

On 18/01/2012, at 10:42, r@golang.org wrote:

> *** Submitted as b0084fd76ac7 ***
> 
> fmt: fix Malloc test
> We need to avoid allocating an extra word for the interface value
> passing the floating-point value as an interface{}. It's easy.
> 
> Fixes issue 2722.
> 
> R=golang-dev, gri
> CC=golang-dev
> http://codereview.appspot.com/5553044
> 
> 
> http://codereview.appspot.com/5553044/

Expand All Messages | Collapse All Messages