Issue 55470048: code review 55470048: net/http: make responseAndError satisfy the net.Error i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55470048: code review 55470048: net/http: make responseAndError satisfy the net.Error i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by rick

Modified:
10 years, 3 months ago

Reviewers:
gobot, bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

net/http: make responseAndError satisfy the net.Error interface Allow clients to check for timeouts without relying on error substring matching. Fixes issue 6185.

Patch Set 1 #

Patch Set 2 : diff -r a5b451d7be59 https://code.google.com/p/go #

Patch Set 3 : diff -r a5b451d7be59 https://code.google.com/p/go #

Patch Set 4 : diff -r a5b451d7be59 https://code.google.com/p/go #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -2 lines)			Patch
	M	src/pkg/net/http/transport.go	View	1	2 chunks	+14 lines, -2 lines	0 comments	Download
	M	src/pkg/net/http/transport_test.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rick

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 3 months ago (2014-02-07 03:05:48 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=2216f3f28a2c *** net/http: make responseAndError satisfy the net.Error interface Allow clients to ...

10 years, 3 months ago (2014-02-12 15:59:53 UTC) #3

This CL appears to have broken the linux-amd64 builder.

Expand All Messages | Collapse All Messages