Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5545058: code review 5545058: net: Dial, ListenPacket with "ip:protocol" network for ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by mikio
Modified:
13 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

net: Dial, ListenPacket with "ip:protocol" network for raw IP sockets Fixes issue 2654.

Patch Set 1 : diff -r f63e838fc121 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 48f06133a092 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f1d4817915e2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8c0e39009d5e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 684a2f9b0b7f https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 6 : diff -r c739d13190cc https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -239 lines) Patch
M src/pkg/net/dial.go View 1 2 3 4 5 5 chunks +97 lines, -84 lines 0 comments Download
M src/pkg/net/ipraw_test.go View 1 2 3 4 5 1 chunk +157 lines, -87 lines 0 comments Download
M src/pkg/net/iprawsock_plan9.go View 1 2 3 4 4 chunks +23 lines, -18 lines 0 comments Download
M src/pkg/net/iprawsock_posix.go View 1 2 3 4 11 chunks +33 lines, -50 lines 0 comments Download
M src/pkg/net/lookup_plan9.go View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 2 months ago (2012-01-15 17:33:49 UTC) #1
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 2 months ago (2012-01-15 17:52:53 UTC) #2
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 2 months ago (2012-01-17 07:44:48 UTC) #3
mikio
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 2 months ago (2012-01-18 21:59:49 UTC) #4
mikio
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 2 months ago (2012-01-19 13:04:28 UTC) #5
rsc
LGTM http://codereview.appspot.com/5545058/diff/12001/src/pkg/net/dial.go File src/pkg/net/dial.go (right): http://codereview.appspot.com/5545058/diff/12001/src/pkg/net/dial.go#newcode74 src/pkg/net/dial.go:74: // For IP networks except internet protocols, addresses ...
13 years, 2 months ago (2012-01-20 18:07:27 UTC) #6
mikio
http://codereview.appspot.com/5545058/diff/12001/src/pkg/net/dial.go File src/pkg/net/dial.go (right): http://codereview.appspot.com/5545058/diff/12001/src/pkg/net/dial.go#newcode74 src/pkg/net/dial.go:74: // For IP networks except internet protocols, addresses have ...
13 years, 2 months ago (2012-01-21 12:50:20 UTC) #7
mikio
13 years, 2 months ago (2012-01-21 12:52:00 UTC) #8 
*** Submitted as http://code.google.com/p/go/source/detail?r=d5b106da84c9 ***

net: Dial, ListenPacket with "ip:protocol" network for raw IP sockets

Fixes issue 2654.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5545058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b