code review 5539050: build: don't use a fixed filename in temp

build: don't use a fixed filename in temp

Fixes issue 2688

[bradfitz, 2012-01-12 22:34:19]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[gri, 2012-01-12 22:37:35]

LGTM

But is this good enough?

On Thu, Jan 12, 2012 at 2:34 PM,  <bradfitz@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> build: don't use a fixed filename in temp
>
> Fixes issue 2688
>
> Please review this at http://codereview.appspot.com/5539050/
>
> Affected files:
>  M doc/progs/run
>
>
> Index: doc/progs/run
> ===================================================================
> --- a/doc/progs/run
> +++ b/doc/progs/run
> @@ -68,7 +68,7 @@
>  done
>
>  # Write to temporary file to avoid mingw bash bug.
> -TMPFILE="/tmp/gotest3"
> +TMPFILE="/tmp/gotest3.$USER"
>
>  function testit {
>        $LD $1.$O
>
>

[rsc, 2012-01-12 22:38:44]

LGTM

[bradfitz, 2012-01-12 22:45:14]

Perfect? No.
Good enough? Yes. :-)

On Thu, Jan 12, 2012 at 2:37 PM, Robert Griesemer <gri@golang.org> wrote:

> LGTM
>
> But is this good enough?
>
> On Thu, Jan 12, 2012 at 2:34 PM,  <bradfitz@golang.org> wrote:
> > Reviewers: golang-dev_googlegroups.com,
> >
> > Message:
> > Hello golang-dev@googlegroups.com,
> >
> > I'd like you to review this change to
> > https://go.googlecode.com/hg
> >
> >
> > Description:
> > build: don't use a fixed filename in temp
> >
> > Fixes issue 2688
> >
> > Please review this at http://codereview.appspot.com/5539050/
> >
> > Affected files:
> >  M doc/progs/run
> >
> >
> > Index: doc/progs/run
> > ===================================================================
> > --- a/doc/progs/run
> > +++ b/doc/progs/run
> > @@ -68,7 +68,7 @@
> >  done
> >
> >  # Write to temporary file to avoid mingw bash bug.
> > -TMPFILE="/tmp/gotest3"
> > +TMPFILE="/tmp/gotest3.$USER"
> >
> >  function testit {
> >        $LD $1.$O
> >
> >
>

[bradfitz, 2012-01-12 22:45:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=5a3b0aca02ef ***

build: don't use a fixed filename in temp

Fixes issue 2688

R=golang-dev, gri, rsc
CC=golang-dev
http://codereview.appspot.com/5539050