Issue 5536057: code review 5536057: image/color: rename modelYCbCr to yCbCrModel.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5536057: code review 5536057: image/color: rename modelYCbCr to yCbCrModel. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bsiegert

Modified:
13 years, 3 months ago

Reviewers:

CC:
nigeltao, crawshaw2, golang-dev

Visibility:
Public.

Description

image/color: rename modelYCbCr to yCbCrModel. This matches the other color models. It seems that this was missed during the review of 5544073.

Patch Set 1 #

Patch Set 2 : diff -r 41777f1070e9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 41777f1070e9 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/image/color/ycbcr.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsiegert

Hello nigeltao@golang.org, david.crawshaw@zentus.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2012-01-18 20:05:54 UTC) #1

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=55013b5f5a83 *** image/color: rename modelYCbCr to yCbCrModel. This matches the other color ...

13 years, 3 months ago (2012-01-18 22:34:44 UTC) #3

bsiegert

13 years, 3 months ago (2012-01-27 21:20:41 UTC) #5

On Fri, Jan 27, 2012 at 22:14,  <bsiegert@gmail.com> wrote:
> *** Abandoned ***
>
> http://codereview.appspot.com/5536057/

Wrong, this has been submitted.

--Benny.

Expand All Messages | Collapse All Messages