Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 5533057: code review 5533057: pkg: add missing godoc comments to windows versions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by brainman
Modified:
13 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

pkg: add missing godoc comments to windows versions Mostly copied comments from unix files.

Patch Set 1 #

Patch Set 2 : diff -r d99e4c71ffc8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d99e4c71ffc8 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5bdb5a13fbc0 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r eea28ac6be16 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -180 lines) Patch
M src/buildscript_darwin_386.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_darwin_amd64.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_freebsd_386.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_freebsd_amd64.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_linux_386.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_linux_amd64.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_linux_arm.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_netbsd_386.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_netbsd_amd64.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_openbsd_386.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_openbsd_amd64.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_plan9_386.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_windows_386.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_windows_amd64.sh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/Makefile View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A src/pkg/net/doc.go View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M src/pkg/net/lookup_plan9.go View 1 2 3 8 chunks +8 lines, -30 lines 0 comments Download
M src/pkg/net/lookup_unix.go View 1 2 3 8 chunks +8 lines, -30 lines 0 comments Download
M src/pkg/net/lookup_windows.go View 1 2 3 8 chunks +8 lines, -17 lines 0 comments Download
M src/pkg/os/Makefile View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/os/dir_plan9.go View 1 2 3 2 chunks +2 lines, -29 lines 0 comments Download
M src/pkg/os/dir_unix.go View 1 2 3 1 chunk +1 line, -13 lines 0 comments Download
M src/pkg/os/dir_windows.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/os/doc.go View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
M src/pkg/os/exec/lp_windows.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/os/exec_plan9.go View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M src/pkg/os/exec_unix.go View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M src/pkg/os/exec_windows.go View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M src/pkg/os/file_unix.go View 1 2 3 1 chunk +1 line, -16 lines 0 comments Download
M src/pkg/os/file_windows.go View 1 2 3 1 chunk +1 line, -16 lines 0 comments Download
M src/pkg/os/sys_bsd.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/sys_linux.go View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/os/sys_plan9.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/sys_windows.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 2 months ago (2012-01-10 05:02:37 UTC) #1
rsc
Hi Alex, Thanks for fixing these. It would be great to have a single copy ...
13 years, 2 months ago (2012-01-10 05:06:08 UTC) #2
brainman
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 2 months ago (2012-01-11 00:01:20 UTC) #3
rsc
LGTM Please sync and re-run all.bash before submit, to update the build scripts. Thanks.
13 years, 2 months ago (2012-01-17 00:25:49 UTC) #4
brainman
13 years, 2 months ago (2012-01-17 05:52:01 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=f1d4817915e2 ***

pkg: add missing godoc comments to windows versions

Mostly copied comments from unix files.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5533057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b