code review 5532088: time: add Since, which returns the time elapsed since s...

time: add Since, which returns the time elapsed since some past time t.

[Sameer Ajmani, 2012-01-18 15:54:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-01-18 18:52:46]

Looks fine.  Was there anything else we had discussed?
I can't find the email thread.

[r, 2012-01-18 19:15:35]

LGTM although I don't encourage a new method/function for every arithmetic
operation.

[Sameer Ajmani, 2012-01-18 19:51:28]

On 2012/01/18 18:52:46, rsc wrote:
> Looks fine.  Was there anything else we had discussed?
> I can't find the email thread.

Russ, you proposed:

I am thinking about adding

// Elapsed returns the time elapsed since t.
// It is shorthand for time.Now().Sub(t).
func (t Time) Elapsed() Duration

// UnixMilli returns the Unix time, the number of milliseconds elapsed
// since January 1, 1970 UTC.
func (t Time) UnixMilli() int64

// UnixMicro returns the Unix time, the number of microseconds elapsed
// since January 1, 1970 UTC.
func (t Time) UnixMicro() int64

[Sameer Ajmani, 2012-01-18 19:52:04]

On 2012/01/18 19:15:35, r wrote:
> LGTM although I don't encourage a new method/function for every arithmetic
> operation.

As much as I like symmetry, I'll resist adding time.Until(t).

[rsc, 2012-01-18 20:02:35]

LGTM

Since makes Elapsed not interesting.
UnixMilli and UnixMicro don't seem so
relevant here, so let's leave them out too.
So just Since.

[Sameer Ajmani, 2012-01-18 20:25:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=a56668df61e3 ***

time: add Since, which returns the time elapsed since some past time t.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5532088