Issue 5531052: code review 5531052: os: add ModeCharDevice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5531052: code review 5531052: os: add ModeCharDevice (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rsc

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

os: add ModeCharDevice This should make conversion from Unix mode to os.FileMode and back not lossy.

Patch Set 1 #

Patch Set 2 : diff -r 9c2406cf1bd2 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 099a872ab835 https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -16 lines)			Patch
M	src/pkg/os/stat_darwin.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/os/stat_freebsd.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/os/stat_linux.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/os/stat_netbsd.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/os/stat_openbsd.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/os/types.go	View	1	2 chunks	+15 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2012-01-09 20:54:47 UTC) #1

rsc

12 years, 3 months ago (2012-01-09 22:22:56 UTC) #3

*** Submitted as 3cd651bb0d3a ***

os: add ModeCharDevice

This should make conversion from Unix mode
to os.FileMode and back not lossy.

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/5531052

Expand All Messages | Collapse All Messages