Issue 5528102: code review 5528102: exp/terminal: add to level Makefile for the (non-Linux?...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5528102: code review 5528102: exp/terminal: add to level Makefile for the (non-Linux?... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by agl1

Modified:
12 years, 3 months ago

Reviewers:
mikio

CC:
golang-dev

Visibility:
Public.

Description

exp/terminal: add to level Makefile for the (non-Linux?) systems that need it.

Patch Set 2 : diff -r 98664c24b18d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 98664c24b18d https://go.googlecode.com/hg/ #

Total comments: 2

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/Makefile	View	1	1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2012-01-15 15:21:56 UTC) #1

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=43ddfca467e9 *** exp/terminal: add to level Makefile for the (non-Linux?) systems that ...

12 years, 3 months ago (2012-01-15 15:22:19 UTC) #2

mikio

http://codereview.appspot.com/5528102/diff/4001/src/pkg/Makefile File src/pkg/Makefile (right): http://codereview.appspot.com/5528102/diff/4001/src/pkg/Makefile#newcode88 src/pkg/Makefile:88: exp/terminal\ Kilroy was here. http://codereview.appspot.com/5528102/diff/4001/src/pkg/Makefile#newcode189 src/pkg/Makefile:189: exp/terminal\ Kilroy was ...

12 years, 3 months ago (2012-01-15 15:32:56 UTC) #3

agl1

12 years, 3 months ago (2012-01-15 15:37:44 UTC) #4

On Sun, Jan 15, 2012 at 10:32 AM,  <mikioh.mikioh@gmail.com> wrote:
> I think you have two options:
> a) remove exp/terminal dependency from exp/ssh
> b) add stub code for other, non-Linux, OSes to exp/terminal

Yes, I've just noticed that a "build linux" tag was mistakenly added
to exp/terminal.

But given that it's 7:30am on a Sunday morning, I'll keep trying to
unbreak it for a while before giving up.

Cheers

AGL

Expand All Messages | Collapse All Messages