Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(522)

Issue 55140043: code review 55140043: misc/cgo/testtls: make test less flaky (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
r, iant
CC:
iant, r, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

misc/cgo/testtls: make test less flaky Now it should always fail on ARM. (The fix is on its way too.)

Patch Set 1 #

Patch Set 2 : diff -r 3a08deffa322 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3a08deffa322 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 27dcbbb2fd4e https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M misc/cgo/testtls/tls.go View 1 2 3 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello iant, r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2014-01-21 18:04:41 UTC) #1
r
LGTM
11 years, 1 month ago (2014-01-21 18:55:55 UTC) #2
iant
LGTM
11 years, 1 month ago (2014-01-21 19:34:53 UTC) #3
dave_cheney.net
https://codereview.appspot.com/55140043/diff/40001/misc/cgo/testtls/tls.go File misc/cgo/testtls/tls.go (right): https://codereview.appspot.com/55140043/diff/40001/misc/cgo/testtls/tls.go#newcode28 misc/cgo/testtls/tls.go:28: t.Fatalf("at end, C.getTLS() = %#x, want %#x", keyVal, val, ...
11 years, 1 month ago (2014-01-21 21:54:23 UTC) #4
rsc
11 years, 1 month ago (2014-01-22 00:44:55 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=cd8f9679d5f1 ***

misc/cgo/testtls: make test less flaky

Now it should always fail on ARM.
(The fix is on its way too.)

R=iant, r, dave
CC=golang-codereviews
https://codereview.appspot.com/55140043

https://codereview.appspot.com/55140043/diff/40001/misc/cgo/testtls/tls.go
File misc/cgo/testtls/tls.go (right):

https://codereview.appspot.com/55140043/diff/40001/misc/cgo/testtls/tls.go#ne...
misc/cgo/testtls/tls.go:28: t.Fatalf("at end, C.getTLS() = %#x, want %#x",
keyVal, val, keyVal)
On 2014/01/21 21:54:23, dfc wrote:
> one too many values passed to Fatalf

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b