code review 5502054: build: multiple fixes to make "go install" work on windows

build: multiple fixes to make "go install" work on windows

[brainman, 2011-12-21 05:37:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-12-21 05:51:13]

LGTM

Sorry for all the mistakes.

[brainman, 2011-12-21 05:57:53]

*** Submitted as http://code.google.com/p/go/source/detail?r=b358942c1ff0 ***

build: multiple fixes to make "go install" work on windows

R=rsc
CC=golang-dev
http://codereview.appspot.com/5502054

[brainman, 2011-12-21 06:00:01]

Tests are still not working. Yet ... :-)

Alex

[bradfitz, 2011-12-21 06:29:26]

This CL modifies auto-generated files without touching their creator script
(buildscript.sh).


On Tue, Dec 20, 2011 at 9:51 PM, <rsc@golang.org> wrote:

> LGTM
>
> Sorry for all the mistakes.
>
>
>
http://codereview.appspot.com/**5502054/<http://codereview.appspot.com/5502054/>
>

[brainman, 2011-12-21 06:30:54]

On 2011/12/21 06:29:26, bradfitz wrote:
> This CL modifies auto-generated files without touching their creator script
> (buildscript.sh).
> 

I have change the "go" command. Therefore the change.

Alex

[bradfitz, 2011-12-21 06:34:43]

On Tue, Dec 20, 2011 at 10:30 PM, <alex.brainman@gmail.com> wrote:

> On 2011/12/21 06:29:26, bradfitz wrote:
>
>> This CL modifies auto-generated files without touching their creator
>>
> script
>
>> (buildscript.sh).
>>
>
>
> I have change the "go" command. Therefore the change.
>

I don't understand.

The top of that file says:

"# AUTO-GENERATED by buildscript.sh; DO NOT EDIT."

Is it not auto-generated by buildscript.sh?
You did edit.
You did not edit buildscript.sh.

It's entirely possible that I'm confused.  My feedback is based entirely on
that warning comment.

[brainman, 2011-12-21 06:37:27]

On 2011/12/21 06:34:43, bradfitz wrote:

> It's entirely possible that I'm confused.  ...

Now you are making a fool of yourself. Look at the contents of buildscript.sh.
It runs new "go" command. I have change the "go" command. It now outputs
different things.

Alex

[brainman, 2011-12-21 06:39:58]

I know, it is complicated. But while we have Russ, we will be OK. :-)

Alex