code review 5492051: io/ioutil: remove another reference to _test

io/ioutil: remove another reference to _test

[rsc, 2011-12-15 23:57:02]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-12-16 00:03:38]

LGTM
On Dec 15, 2011 3:57 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> io/ioutil: remove another reference to _test
>
> Please review this at
http://codereview.appspot.com/**5492051/<http://codereview.appspot.com/5492051/>
>
> Affected files:
>  M src/pkg/io/ioutil/ioutil_test.**go
>
>
> Index: src/pkg/io/ioutil/ioutil_test.**go
> ==============================**==============================**=======
> --- a/src/pkg/io/ioutil/ioutil_**test.go
> +++ b/src/pkg/io/ioutil/ioutil_**test.go
> @@ -70,26 +70,26 @@
>                t.Fatalf("ReadDir %s: error expected, none found", dirname)
>        }
>
> -       dirname = "."
> +       dirname = ".."
>        list, err := ReadDir(dirname)
>        if err != nil {
>                t.Fatalf("ReadDir %s: %v", dirname, err)
>        }
>
> -       foundTest := false
> -       foundTestDir := false
> +       foundFile := false
> +       foundSubDir := false
>        for _, dir := range list {
>                switch {
> -               case !dir.IsDir() && dir.Name() == "ioutil_test.go":
> -                       foundTest = true
> -               case dir.IsDir() && dir.Name() == "_test":
> -                       foundTestDir = true
> +               case !dir.IsDir() && dir.Name() == "io_test.go":
> +                       foundFile = true
> +               case dir.IsDir() && dir.Name() == "ioutil":
> +                       foundSubDir = true
>                }
>        }
> -       if !foundTest {
> -               t.Fatalf("ReadDir %s: test file not found", dirname)
> +       if !foundFile {
> +               t.Fatalf("ReadDir %s: io_test.go file not found", dirname)
>        }
> -       if !foundTestDir {
> -               t.Fatalf("ReadDir %s: _test directory not found", dirname)
> +       if !foundSubDir {
> +               t.Fatalf("ReadDir %s: ioutil directory not found", dirname)
>        }
>  }
>
>
>

[rsc, 2011-12-16 00:32:53]

*** Submitted as http://code.google.com/p/go/source/detail?r=323b63d5b04c ***

io/ioutil: remove another reference to _test

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5492051