code review 5491043: spec: skip carriage returns in raw literals

spec: skip carriage returns in raw literals

This change guarantees that whether the line ending convention
when the source is created includes carriage returns is irrelevant
to the value of the string. See issue 680.

The compilers do not yet implement this.

[r, 2011-12-15 00:16:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-12-15 00:20:50]

On 15 December 2011 11:16,  <r@golang.org> wrote:
> will address issue six hundred and eighty.

If you write this as "issue 680" then it will be a clickable link in
the code.google.com interface.

[r2, 2011-12-15 00:23:14]

On Dec 14, 2011, at 4:20 PM, Andrew Gerrand wrote:

> On 15 December 2011 11:16,  <r@golang.org> wrote:
>> will address issue six hundred and eighty.
> 
> If you write this as "issue 680" then it will be a clickable link in
> the code.google.com interface.

i deliberately avoided writing it because i don't know the rules for it being
marked as resolved.

-rob

[gri, 2011-12-15 00:29:00]

FYI

http://codereview.appspot.com/5491043/diff/1/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/5491043/diff/1/doc/go_spec.html#newcode458
doc/go_spec.html:458: are skipped, that is, not included in the raw string
value.
maybe: s/skipped/discarded/ (stronger)

[r, 2011-12-15 00:39:57]

Hello golang-dev@googlegroups.com, adg@golang.org, r@google.com, gri@golang.org
(cc: golang-dev@googlegroups.com),

Please take another look.

[gri, 2011-12-15 00:43:22]

LGTM

[adg, 2011-12-15 00:53:29]

On 15 December 2011 11:23, Rob 'Commander' Pike <r@google.com> wrote:
>
> On Dec 14, 2011, at 4:20 PM, Andrew Gerrand wrote:
>
>> On 15 December 2011 11:16,  <r@golang.org> wrote:
>>> will address issue six hundred and eighty.
>>
>> If you write this as "issue 680" then it will be a clickable link in
>> the code.google.com interface.
>
> i deliberately avoided writing it because i don't know the rules for it being
marked as resolved.

http://code.google.com/p/support/wiki/IssueTracker#Integration_with_version_c...

The issue tracker handles an easy-to-use "short form" syntax to set an
issue's status to Fixed. This would be used when the source code
change you are committing completely fixes a defect or implements a
requested enhancement. The syntax is any one of the following:

(Fixes issue NNN)	 Enclose command in parentheses
Fixes issue NNN.	 Full sentence in your log message description
Fixes issue NNN	 On a line by itself

The word Fixes can replaced with Closes or Resolves. The issue number
can have a leading pound-sign (#) or not.

[rsc, 2011-12-15 02:52:02]

LGTM

[r, 2011-12-15 04:12:23]

Hello golang-dev@googlegroups.com, adg@golang.org, r@google.com, gri@golang.org,
rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r2, 2011-12-15 04:12:54]

I reworded it. PTAL

-rob

[iant, 2011-12-15 05:50:27]

LGTM

[r, 2011-12-15 05:51:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=2d9ac660f013 ***

spec: skip carriage returns in raw literals

This change guarantees that whether the line ending convention
when the source is created includes carriage returns is irrelevant
to the value of the string. See issue 680.

The compilers do not yet implement this.

R=golang-dev, adg, r, gri, rsc, iant
CC=golang-dev
http://codereview.appspot.com/5491043