code review 5484076: pkg/math: undo manual inlining of IsInf and IsNaN

pkg/math: undo manual inlining of IsInf and IsNaN

[lvd, 2012-02-01 13:59:32]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[lvd, 2012-02-01 14:03:02]

http://codereview.appspot.com/5484076/diff/3001/src/pkg/math/asinh.go
File src/pkg/math/asinh.go (right):

http://codereview.appspot.com/5484076/diff/3001/src/pkg/math/asinh.go#newcode46
src/pkg/math/asinh.go:46: if IsNaN(x) || IsInf(x, 0) {
in other places this becomes IsInf(x, -1) || IsInf(x, 1)

[rsc, 2012-02-01 14:11:45]

LGTM

http://codereview.appspot.com/5484076/diff/3001/src/pkg/math/asinh.go
File src/pkg/math/asinh.go (right):

http://codereview.appspot.com/5484076/diff/3001/src/pkg/math/asinh.go#newcode46
src/pkg/math/asinh.go:46: if IsNaN(x) || IsInf(x, 0) {
On 2012/02/01 14:03:03, lvd wrote:
> in other places this becomes IsInf(x, -1) || IsInf(x, 1)

I am not quite sure what you mean here.
I looked through the rest of the CL for such an || but I don't see any.

[lvd, 2012-02-01 15:08:35]

*** Submitted as http://code.google.com/p/go/source/detail?r=dc4e0794db8b ***

pkg/math: undo manual inlining of IsInf and IsNaN

R=rsc
CC=golang-dev
http://codereview.appspot.com/5484076