Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(504)

Issue 5484071: code review 5484071: test/bench/go1: first draft of Go 1 benchmark suite (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by rsc
Modified:
12 years, 3 months ago
Reviewers:
CC:
golang-dev, r2, bradfitz, adg, r
Visibility:
Public.

Description

test/bench/go1: first draft of Go 1 benchmark suite I have included a few important microbenchmarks, but the overall intent is to have mostly end-to-end benchmarks timing real world operations. The jsondata.go file is a summary of agl's activity in various open source repositories. It gets used as test data for many of the benchmarks. Everything links into one binary (even the test data) so that it is easy to run the benchmarks on many computers: there is just one file to copy around.

Patch Set 1 #

Patch Set 2 : diff -r 4d57f439ae4d https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 3 : diff -r 4d57f439ae4d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4d57f439ae4d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4d57f439ae4d https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 6 : diff -r 4d57f439ae4d https://go.googlecode.com/hg/ #

Total comments: 5

Patch Set 7 : diff -r 99c8839944fa https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2553 lines, -1 line) Patch
M src/clean.bash View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M src/run.bash View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
A test/bench/go1/Makefile View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
A test/bench/go1/binarytree_test.go View 1 2 3 4 1 chunk +63 lines, -0 lines 0 comments Download
A test/bench/go1/dummy.go View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A test/bench/go1/fannkuch_test.go View 1 2 3 4 5 1 chunk +84 lines, -0 lines 0 comments Download
A test/bench/go1/fasta_test.go View 1 2 3 4 1 chunk +164 lines, -0 lines 0 comments Download
A test/bench/go1/gob_test.go View 1 2 3 4 5 1 chunk +95 lines, -0 lines 0 comments Download
A test/bench/go1/gzip_test.go View 1 2 3 4 1 chunk +69 lines, -0 lines 0 comments Download
A test/bench/go1/json_test.go View 1 2 3 4 1 chunk +84 lines, -0 lines 0 comments Download
A test/bench/go1/jsondata_test.go View 1 2 3 4 5 6 1 chunk +1818 lines, -0 lines 0 comments Download
A test/bench/go1/revcomp_test.go View 1 2 3 4 1 chunk +85 lines, -0 lines 0 comments Download
A test/bench/go1/template_test.go View 1 2 3 4 5 6 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 16
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 3 months ago (2011-12-13 23:08:09 UTC) #1
rsc
code review refused to upload jsondata.go. it looks like --- // Input for json benchmark. ...
12 years, 3 months ago (2011-12-13 23:10:12 UTC) #2
r2
On Dec 13, 2011, at 3:10 PM, Russ Cox wrote: > code review refused to ...
12 years, 3 months ago (2011-12-13 23:11:58 UTC) #3
rsc
i can make it a 0.5 MB file by gzipping it and then using that ...
12 years, 3 months ago (2011-12-13 23:14:58 UTC) #4
r2
On Dec 13, 2011, at 3:14 PM, Russ Cox wrote: > i can make it ...
12 years, 3 months ago (2011-12-13 23:17:27 UTC) #5
rsc
On Tue, Dec 13, 2011 at 18:17, Rob 'Commander' Pike <r@google.com> wrote: > it's 1.5MB ...
12 years, 3 months ago (2011-12-13 23:18:34 UTC) #6
bradfitz
On Tue, Dec 13, 2011 at 3:18 PM, Russ Cox <rsc@golang.org> wrote: > On Tue, ...
12 years, 3 months ago (2011-12-13 23:25:41 UTC) #7
adg
http://codereview.appspot.com/5484071/diff/2001/test/bench/go1/benchmark.go File test/bench/go1/benchmark.go (right): http://codereview.appspot.com/5484071/diff/2001/test/bench/go1/benchmark.go#newcode1 test/bench/go1/benchmark.go:1: package main I think you left this file in ...
12 years, 3 months ago (2011-12-14 00:19:42 UTC) #8
adg
http://codereview.appspot.com/5484071/diff/2001/test/bench/go1/main.go File test/bench/go1/main.go (right): http://codereview.appspot.com/5484071/diff/2001/test/bench/go1/main.go#newcode55 test/bench/go1/main.go:55: re := regexp.MustCompile(pat) more friendly to use Compile and ...
12 years, 3 months ago (2011-12-14 00:25:07 UTC) #9
rsc
PTAL I stopped trying to invent a new benchmark framework. I also reduced the json ...
12 years, 3 months ago (2011-12-14 03:35:28 UTC) #10
adg
LGTM Much better!
12 years, 3 months ago (2011-12-14 03:47:18 UTC) #11
r
the CL mentions jsondata.go but there's no such file. http://codereview.appspot.com/5484071/diff/5012/src/run.bash File src/run.bash (right): http://codereview.appspot.com/5484071/diff/5012/src/run.bash#newcode95 src/run.bash:95: ...
12 years, 3 months ago (2011-12-14 03:53:48 UTC) #12
rsc
> http://codereview.appspot.com/5484071/diff/5012/src/run.bash#newcode95 > src/run.bash:95: for i in ../misc/dashboard/builder ../misc/goplay > ../test/bench/go1 > no running? maybe ...
12 years, 3 months ago (2011-12-15 16:36:02 UTC) #13
r
LGTM http://codereview.appspot.com/5484071/diff/8001/test/bench/go1/jsondata_test.go File test/bench/go1/jsondata_test.go (right): http://codereview.appspot.com/5484071/diff/8001/test/bench/go1/jsondata_test.go#newcode1 test/bench/go1/jsondata_test.go:1: // Input for json benchmark. copyright? http://codereview.appspot.com/5484071/diff/8001/test/bench/go1/jsondata_test.go#newcode1 test/bench/go1/jsondata_test.go:1: ...
12 years, 3 months ago (2011-12-15 17:22:07 UTC) #14
rsc
On Thu, Dec 15, 2011 at 12:22, <r@golang.org> wrote: > i suggest you look at ...
12 years, 3 months ago (2011-12-15 17:32:51 UTC) #15
rsc
12 years, 3 months ago (2011-12-15 17:33:05 UTC) #16
*** Submitted as http://code.google.com/p/go/source/detail?r=5ec032f55cff ***

test/bench/go1: first draft of Go 1 benchmark suite

I have included a few important microbenchmarks,
but the overall intent is to have mostly end-to-end
benchmarks timing real world operations.

The jsondata.go file is a summary of agl's
activity in various open source repositories.
It gets used as test data for many of the benchmarks.

Everything links into one binary (even the test data)
so that it is easy to run the benchmarks on many
computers: there is just one file to copy around.

R=golang-dev, r, bradfitz, adg, r
CC=golang-dev
http://codereview.appspot.com/5484071
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b