Issue 54820044: code review 54820044: go.tools/godoc: don't associate builtin nil with a type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54820044: code review 54820044: go.tools/godoc: don't associate builtin nil with a type (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by gri

Modified:
10 years, 2 months ago

Reviewers:
bgarcia

CC:
bgarcia, r, bradfitz, golang-codereviews

Visibility:
Public.

Description

go.tools/godoc: don't associate builtin nil with a type Special case for (fake) package builtin: don't associate any constant, variable, or factory function with a type. Fixes issue 6645.

Patch Set 1 #

Patch Set 2 : diff -r 3e0fa44ee226 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 3e0fa44ee226 https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 4 : diff -r 3e0fa44ee226 https://code.google.com/p/go.tools #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	godoc/cmdline.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	godoc/server.go	View	1	3 chunks	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello bgarcia@golang.org, r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 2 months ago (2014-02-04 01:03:56 UTC) #1

bradfitz

A test would be nice. We're trying to be better these days with godoc/..., now ...

10 years, 2 months ago (2014-02-04 15:53:01 UTC) #3

gri

Re: tests. This is slightly annoying to test - what we really want is to ...

10 years, 2 months ago (2014-02-04 18:25:51 UTC) #4

gri

10 years, 2 months ago (2014-02-04 18:26:42 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=377f4e9d8adc&repo=tools ***

go.tools/godoc: don't associate builtin nil with a type

Special case for (fake) package builtin: don't associate
any constant, variable, or factory function with a type.

Fixes issue 6645.

LGTM=bgarcia
R=bgarcia, r, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/54820044

Expand All Messages | Collapse All Messages