Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(515)

Issue 54760044: code review 54760044: cmd/gc: add the word 'archive' to the documentation for... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by r
Modified:
11 years, 1 month ago
Reviewers:
dave, iant
CC:
iant, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

cmd/gc: add the word 'archive' to the documentation for -pack The term "package file" is unclear.

Patch Set 1 #

Patch Set 2 : diff -r c057b92310eb https://code.google.com/p/go #

Total comments: 1

Patch Set 3 : diff -r c057b92310eb https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 654b2703fcc4 https://code.google.com/p/go #

Patch Set 5 : diff -r 654b2703fcc4 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/doc.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12
r
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2014-01-21 20:41:21 UTC) #1
dave_cheney.net
why not drop package altogether and say 'write an archive file rather than an object ...
11 years, 1 month ago (2014-01-21 21:50:14 UTC) #2
r
Hello iant@golang.org, dave@cheney.net (cc: golang-codereviews@googlegroups.com), Please take another look.
11 years, 1 month ago (2014-01-21 22:05:28 UTC) #3
dave_cheney.net
LGTM. > On 22 Jan 2014, at 9:05, r@golang.org wrote: > > Hello iant@golang.org, dave@cheney.net ...
11 years, 1 month ago (2014-01-21 22:24:01 UTC) #4
iant
https://codereview.appspot.com/54760044/diff/20001/src/cmd/gc/doc.go File src/cmd/gc/doc.go (right): https://codereview.appspot.com/54760044/diff/20001/src/cmd/gc/doc.go#newcode41 src/cmd/gc/doc.go:41: write an archive file (see go tool pack) rather ...
11 years, 1 month ago (2014-01-21 22:29:40 UTC) #5
r
Hello iant@golang.org, dave@cheney.net (cc: golang-codereviews@googlegroups.com), Please take another look.
11 years, 1 month ago (2014-01-22 00:04:37 UTC) #6
iant
https://codereview.appspot.com/54760044/diff/30001/src/cmd/gc/doc.go File src/cmd/gc/doc.go (right): https://codereview.appspot.com/54760044/diff/30001/src/cmd/gc/doc.go#newcode41 src/cmd/gc/doc.go:41: write an archive file (for go tool pack) rather ...
11 years, 1 month ago (2014-01-22 00:28:43 UTC) #7
r
Please suggest the wording you want then. There is no such thing as a "package ...
11 years, 1 month ago (2014-01-22 00:33:05 UTC) #8
iant
On Tue, Jan 21, 2014 at 4:32 PM, Rob Pike <r@golang.org> wrote: > Please suggest ...
11 years, 1 month ago (2014-01-22 00:43:37 UTC) #9
r
Hello iant@golang.org, dave@cheney.net (cc: golang-codereviews@googlegroups.com), Please take another look.
11 years, 1 month ago (2014-01-22 23:42:19 UTC) #10
iant
LGTM Sorry for all the trouble.
11 years, 1 month ago (2014-01-22 23:51:56 UTC) #11
r
11 years, 1 month ago (2014-01-22 23:54:37 UTC) #12
*** Submitted as https://code.google.com/p/go/source/detail?r=7abe32ccffb1 ***

cmd/gc: add the word 'archive' to the documentation for -pack
The term "package file" is unclear.

R=iant, dave
CC=golang-codereviews
https://codereview.appspot.com/54760044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b