Issue 54740044: code review 54740044: io: clarify MultiReader documentation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54740044: code review 54740044: io: clarify MultiReader documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by adg

Modified:
10 years, 3 months ago

Reviewers:
minux1, gobot, brainman

CC:
golang-codereviews, minux1

Visibility:
Public.

Description

io: clarify MultiReader documentation Fixes issue 7216.

Patch Set 2 : diff -r cd8d13f7fcd6 https://code.google.com/p/go #

Patch Set 3 : diff -r 369547fa0881 https://code.google.com/p/go #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/io/multi.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 3 months ago (2014-01-28 07:09:47 UTC) #1

minux1

https://codereview.appspot.com/54740044/diff/1/src/pkg/io/multi.go File src/pkg/io/multi.go (right): https://codereview.appspot.com/54740044/diff/1/src/pkg/io/multi.go#newcode29 src/pkg/io/multi.go:29: // inputs have returned EOF, Read will return EOF. ...

10 years, 3 months ago (2014-01-28 07:14:23 UTC) #3

adg

10 years, 3 months ago (2014-01-28 07:17:11 UTC) #4

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=32588f5eb092 *** io: clarify MultiReader documentation Fixes issue 7216. LGTM=minux.ma R=golang-codereviews, minux.ma ...

10 years, 3 months ago (2014-01-28 08:49:40 UTC) #6

gobot

This CL appears to have broken the windows-386-ec2 builder.

10 years, 3 months ago (2014-01-28 09:07:54 UTC) #7

brainman

10 years, 3 months ago (2014-01-28 09:44:57 UTC) #8

Message was sent while issue was closed.

On 2014/01/28 09:07:54, gobot wrote:
> This CL appears to have broken the windows-386-ec2 builder.

https://code.google.com/p/go/issues/detail?id=6636

Alex

Expand All Messages | Collapse All Messages