Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14179)

Issue 54570046: code review 54570046: cmd/gc: lower OCAP/OLEN for chans into runtime calls

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by dvyukov
Modified:
10 years, 1 month ago
Visibility:
Public.

Description

cmd/gc: lower OCAP/OLEN for chans into runtime calls Allows more flexibility in representation of chans. In preparation for larger chan rewrite. I doubt it can affect performance of sensible Go programs.

Patch Set 1 #

Patch Set 2 : diff -r d815870876a1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d815870876a1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r d815870876a1 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -77 lines) Patch
M src/cmd/5g/cgen.c View 1 2 chunks +1 line, -23 lines 0 comments Download
M src/cmd/6g/cgen.c View 1 2 chunks +2 lines, -24 lines 0 comments Download
M src/cmd/8g/cgen.c View 1 2 chunks +1 line, -23 lines 0 comments Download
M src/cmd/gc/builtin.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/runtime.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/walk.c View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/pkg/runtime/chan.c View 1 2 chunks +35 lines, -7 lines 0 comments Download

Messages

Total messages: 12
dvyukov
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 2 months ago (2014-01-27 20:23:15 UTC) #1
oleku
Hi, What are the issues with current chan implementation and what are we trying to ...
10 years, 2 months ago (2014-01-27 22:34:00 UTC) #2
dvyukov
On Tue, Jan 28, 2014 at 2:33 AM, <oleku.konko@gmail.com> wrote: > > Hi, What are ...
10 years, 2 months ago (2014-01-28 18:50:01 UTC) #3
oleku
Cool .. can't wait to see what you would come up with :) On Tuesday, ...
10 years, 2 months ago (2014-01-28 19:50:58 UTC) #4
dvyukov
Here we go: https://docs.google.com/a/google.com/document/d/1yIAYmbvL3JxOKOjuCyon7JhW4cSv1wy5hC0ApeGMV9s/pub On Tue, Jan 28, 2014 at 11:50 PM, <oleku.konko@gmail.com> wrote: > ...
10 years, 2 months ago (2014-02-03 15:42:52 UTC) #5
dvyukov
On Mon, Feb 3, 2014 at 7:42 PM, Dmitry Vyukov <dvyukov@google.com> wrote: > Here we ...
10 years, 2 months ago (2014-02-03 15:43:38 UTC) #6
oleku
Impressively splendid , this numbers (https://codereview.appspot.com/12544043/) are scary .... Nice One .. Well done :) ...
10 years, 2 months ago (2014-02-03 16:51:11 UTC) #7
gobot
R=rsc@golang.org (assigned by dvyukov@google.com)
10 years, 2 months ago (2014-02-12 18:40:57 UTC) #8
rsc
No. The more complex chan rewrite is not scheduled for Go 1.3, so I do ...
10 years, 2 months ago (2014-02-12 19:02:22 UTC) #9
oleku
Can please you explain better what you mean by "The more complex chan rewrite is ...
10 years, 2 months ago (2014-02-13 11:07:17 UTC) #10
iant
On Thu, Feb 13, 2014 at 3:07 AM, <oleku.konko@gmail.com> wrote: > Can please you explain ...
10 years, 2 months ago (2014-02-13 17:09:49 UTC) #11
rsc
10 years, 1 month ago (2014-03-05 19:17:39 UTC) #12
R=close

please reopen after go 1.3 is out if it is still relevant
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b