Issue 5453067: code review 5453067: crypto/x509: if a parent cert has a raw subject, use it.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5453067: code review 5453067: crypto/x509: if a parent cert has a raw subject, use it. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by agl1

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

crypto/x509: if a parent cert has a raw subject, use it. This avoids a problem when creating certificates with parents that were produce by other code: the Go structures don't contain all the information about the various ASN.1 string types etc and so that information would otherwise be lost.

Patch Set 1 #

Patch Set 2 : diff -r 8eb71b50b26f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8eb71b50b26f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8eb71b50b26f https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/pkg/crypto/x509/x509.go	View	1	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-12-06 21:35:46 UTC) #1

agl1

13 years, 4 months ago (2011-12-06 21:43:28 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ad6231845b03 ***

crypto/x509: if a parent cert has a raw subject, use it.

This avoids a problem when creating certificates with parents that
were produce by other code: the Go structures don't contain all the
information about the various ASN.1 string types etc and so that
information would otherwise be lost.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5453067

Expand All Messages | Collapse All Messages