Issue 5451079: code review 5451079: gofmt -s misc src

Issue 5451079: code review 5451079: gofmt -s misc src (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:
adg

CC:
golang-dev, bradfitz, gri

Visibility:
Public.

Description

gofmt -s misc src

Patch Set 1 #

Patch Set 2 : diff -r f44321ca90e1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f1194e89f56f https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 90b1026581f1 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+325 lines, -325 lines)			Patch
M	misc/dashboard/app/build/test.go	View	1	1 chunk	+1 line, -1 line	1 comment	Download
M	src/cmd/cgo/gcc.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/cgo/out.go	View	1	1 chunk	+16 lines, -16 lines	0 comments	Download
M	src/cmd/gofix/error.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gofix/hashsum.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gofix/httpheaders.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gofix/reflect.go	View	1	3 chunks	+36 lines, -36 lines	0 comments	Download
M	src/cmd/gofix/template.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gofix/timefileinfo.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/goinstall/download.go	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/cmd/gotest/flag.go	View	1	1 chunk	+14 lines, -14 lines	0 comments	Download
M	src/pkg/archive/tar/reader_test.go	View	1	6 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pkg/archive/tar/writer_test.go	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/compress/flate/deflate_test.go	View	1	1 chunk	+29 lines, -29 lines	0 comments	Download
M	src/pkg/compress/flate/flate_test.go	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/crypto/tls/cipher_suites.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/pkg/debug/macho/file_test.go	View	1	4 chunks	+40 lines, -40 lines	0 comments	Download
M	src/pkg/debug/pe/file_test.go	View	1	1 chunk	+27 lines, -27 lines	0 comments	Download
M	src/pkg/encoding/json/decode_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/encoding/xml/marshal_test.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/exp/ssh/cipher.go	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/pkg/go/parser/parser.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/parser.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/html/render_test.go	View	1	5 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/html/template/escape_test.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/net/http/cookie_test.go	View	1	3 chunks	+12 lines, -12 lines	0 comments	Download
M	src/pkg/net/mail/message_test.go	View	1	9 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/old/template/template_test.go	View	1	17 chunks	+56 lines, -56 lines	0 comments	Download
M	src/pkg/path/filepath/path_test.go	View	1	1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-12-02 18:13:30 UTC) #1

bradfitz

LGTM Two nits, but I don't really care. Can fix next time that file's touched ...

13 years, 4 months ago (2011-12-02 18:24:43 UTC) #2

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=e77129fbe42f *** gofmt -s misc src R=golang-dev, bradfitz, gri CC=golang-dev http://codereview.appspot.com/5451079

13 years, 4 months ago (2011-12-02 19:14:28 UTC) #4

adg

13 years, 4 months ago (2011-12-05 02:35:31 UTC) #5

http://codereview.appspot.com/5451079/diff/34/misc/dashboard/app/build/test.go
File misc/dashboard/app/build/test.go (right):

http://codereview.appspot.com/5451079/diff/34/misc/dashboard/app/build/test.g...
misc/dashboard/app/build/test.go:39: {Name: "Go", Path: ""},
Please don't gofix misc/dashboard/app. It needs to build against r60.3 for app
engine.

Expand All Messages | Collapse All Messages