Issue 5450061: code review 5450061: go/doc: better headscan

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5450061: code review 5450061: go/doc: better headscan (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by gri

Modified:
12 years, 4 months ago

Reviewers:

CC:
golang-dev, r2, r

Visibility:
Public.

Description

go/doc: better headscan - scan all comments not just the package documentation - declutter output so that false positives are more easily spotted - count the number of headings to quickly see differences - minor tweaks

Patch Set 1 #

Patch Set 2 : diff -r deeec5c15f88 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r deeec5c15f88 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r deeec5c15f88 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r deeec5c15f88 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 3541add60f81 https://go.googlecode.com/hg/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -24 lines)			Patch
M	src/pkg/go/doc/comment.go	View	1	5 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/go/doc/comment_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/doc/headscan.go	View	1 2	1 chunk	+74 lines, -16 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 4 months ago (2011-12-01 19:21:41 UTC) #1

can we see the effect on a canary? (or even a blue-footed booby?) that is, ...

12 years, 4 months ago (2011-12-01 19:23:48 UTC) #2

gri

12 years, 4 months ago (2011-12-01 19:50:17 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b83e1a8c4d73 ***

go/doc: better headscan

- scan all comments not just the package documentation
- declutter output so that false positives are more easily spotted
- count the number of headings to quickly see differences
- minor tweaks

R=golang-dev, r, r
CC=golang-dev
http://codereview.appspot.com/5450061

Expand All Messages | Collapse All Messages