code review 5447069: use new strconv API

use new strconv API

All but 3 cases (in gcimporter.go and hixie.go)
are automatic conversions using gofix.

No attempt is made to use the new Append functions
even though there are definitely opportunities.

[rsc, 2011-12-01 22:43:47]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-12-01 23:01:57]

LGTM
- gri

On Thu, Dec 1, 2011 at 2:43 PM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> use new strconv API
>
> All but 3 cases (in gcimporter.go and hixie.go)
> are automatic conversions using gofix.
>
> No attempt is made to use the new Append functions
> even though there are definitely opportunities.
>
> Please review this at http://codereview.appspot.com/5447069/
>
> Affected files:
>  M doc/talks/io2010/eval1.go
>  M doc/talks/io2010/eval2.go
>  M misc/cgo/stdio/fib.go
>  M misc/dashboard/builder/http.go
>  M src/cmd/cgo/gcc.go
>  M src/cmd/goinstall/download.go
>  M src/cmd/gotest/flag.go
>  M src/pkg/archive/tar/reader.go
>  M src/pkg/archive/tar/writer.go
>  M src/pkg/compress/flate/huffman_bit_writer.go
>  M src/pkg/compress/flate/inflate.go
>  M src/pkg/crypto/openpgp/write.go
>  M src/pkg/crypto/tls/handshake_server_test.go
>  M src/pkg/debug/dwarf/buf.go
>  M src/pkg/debug/dwarf/const.go
>  M src/pkg/debug/dwarf/type.go
>  M src/pkg/debug/elf/elf.go
>  M src/pkg/debug/macho/macho.go
>  M src/pkg/encoding/ascii85/ascii85.go
>  M src/pkg/encoding/asn1/common.go
>  M src/pkg/encoding/base32/base32.go
>  M src/pkg/encoding/base64/base64.go
>  M src/pkg/encoding/git85/git.go
>  M src/pkg/encoding/json/decode.go
>  M src/pkg/encoding/json/encode.go
>  M src/pkg/encoding/xml/marshal.go
>  M src/pkg/encoding/xml/read.go
>  M src/pkg/encoding/xml/xml.go
>  M src/pkg/exp/norm/maketables.go
>  M src/pkg/exp/norm/normregtest.go
>  M src/pkg/exp/sql/convert.go
>  M src/pkg/exp/sql/driver/types.go
>  M src/pkg/exp/types/gcimporter.go
>  M src/pkg/expvar/expvar.go
>  M src/pkg/flag/flag.go
>  M src/pkg/fmt/format.go
>  M src/pkg/fmt/scan.go
>  M src/pkg/html/template/css_test.go
>  M src/pkg/image/png/writer.go
>  M src/pkg/net/http/cgi/child.go
>  M src/pkg/net/http/chunked.go
>  M src/pkg/net/http/fs.go
>  M src/pkg/net/http/httputil/chunked.go
>  M src/pkg/net/http/pprof/pprof.go
>  M src/pkg/net/http/server.go
>  M src/pkg/net/http/transfer.go
>  M src/pkg/net/mail/message.go
>  M src/pkg/old/template/parse.go
>  M src/pkg/reflect/tostring_test.go
>  M src/pkg/regexp/syntax/prog.go
>  M src/pkg/regexp/syntax/regexp.go
>  M src/pkg/text/template/parse/node.go
>  M src/pkg/time/time_test.go
>  M src/pkg/unicode/maketables.go
>  M src/pkg/websocket/hixie.go
>  M test/fixedbugs/bug120.go
>  M test/fixedbugs/bug260.go
>
>

[rsc, 2011-12-05 20:48:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=3272ed00e536 ***

use new strconv API

All but 3 cases (in gcimporter.go and hixie.go)
are automatic conversions using gofix.

No attempt is made to use the new Append functions
even though there are definitely opportunities.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5447069