Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(517)

Issue 5440071: code review 5440071: time: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by brainman
Modified:
12 years, 4 months ago
Reviewers:
adg
CC:
rsc, golang-dev
Visibility:
Public.

Description

time: fix windows build

Patch Set 1 #

Patch Set 2 : diff -r 69cec8583a92 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 69cec8583a92 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e22dbef7457e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/time/zoneinfo_windows.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
brainman
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 4 months ago (2011-12-01 04:24:31 UTC) #1
rsc
LGTM I was *so* close. :-)
12 years, 4 months ago (2011-12-01 04:25:00 UTC) #2
rsc
Well, I suppose if close means 292 billion years off. Anyway, thanks very much for ...
12 years, 4 months ago (2011-12-01 04:26:15 UTC) #3
brainman
*** Submitted as http://code.google.com/p/go/source/detail?r=b295fb8acebe *** time: fix windows build R=rsc CC=golang-dev http://codereview.appspot.com/5440071
12 years, 4 months ago (2011-12-01 04:26:35 UTC) #4
brainman
On 2011/12/01 04:25:00, rsc wrote: > LGTM > > I was *so* close. :-) I ...
12 years, 4 months ago (2011-12-01 04:28:18 UTC) #5
adg
12 years, 4 months ago (2011-12-01 04:44:01 UTC) #6
Thanks Alex. When the dashboard goes green (black) I'll submit the weekly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b