Issue 5437060: code review 5437060: time: fix timer stop

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5437060: code review 5437060: time: fix timer stop (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by dvyukov

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, adg, mdbrown

Visibility:
Public.

Description

time: fix timer stop Due to data structure corruption, some timers could not be removed. Fixes issue 2495.

Patch Set 2 : diff -r 221f3eb76b52 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r 221f3eb76b52 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 221f3eb76b52 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6ba8b70da6be https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -3 lines)			Patch
	M	src/pkg/runtime/time.goc	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download
	M	src/pkg/time/sleep_test.go	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, mdbrown@google.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-11-24 18:27:55 UTC) #1

dvyukov

http://codereview.appspot.com/5437060/diff/2001/src/pkg/runtime/time.goc File src/pkg/runtime/time.goc (left): http://codereview.appspot.com/5437060/diff/2001/src/pkg/runtime/time.goc#oldcode138 src/pkg/runtime/time.goc:138: siftdown(i); if there are a lot of timers with ...

13 years, 3 months ago (2011-11-24 18:28:05 UTC) #2

dvyukov

13 years, 3 months ago (2011-11-25 11:13:29 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c5f4de48505f ***

time: fix timer stop
Due to data structure corruption,
some timers could not be removed.
Fixes issue 2495.

R=golang-dev, adg
CC=golang-dev, mdbrown
http://codereview.appspot.com/5437060

Expand All Messages | Collapse All Messages