Issue 5437045: code review 5437045: html: parse DOCTYPE into name and public and system ide...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5437045: code review 5437045: html: parse DOCTYPE into name and public and system ide... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by andybalholm

Modified:
13 years, 3 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r 4b38f89d933d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4b38f89d933d https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -6 lines)			Patch
M	src/pkg/html/parse.go	View	1	2 chunks	+54 lines, -4 lines	0 comments	Download
M	src/pkg/html/parse_test.go	View	1	2 chunks	+19 lines, -2 lines	0 comments	Download
M	src/pkg/html/render.go	View	1	3 chunks	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-11-23 17:01:54 UTC) #1

nigeltao

13 years, 3 months ago (2011-11-23 22:29:10 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f68df3b9a830 ***

html: parse DOCTYPE into name and public and system identifiers

Pass tests2.dat, test 59:
<!DOCTYPE <!DOCTYPE HTML>><!--<!--x-->-->

| <!DOCTYPE <!doctype>
| <html>
|   <head>
|   <body>
|     ">"
|     <!-- <!--x -->
|     "-->"

Pass all the tests in doctype01.dat.

Also pass tests2.dat, test 60:
<!doctype html><div><form></form><div></div></div>

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5437045

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages