Issue 5436063: code review 5436063: text/template: fix bug in Clone

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5436063: code review 5436063: text/template: fix bug in Clone (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by r

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

text/template: fix bug in Clone Cloned template copied the root template incorrectly. Add test of self-consistency.

Patch Set 1 #

Patch Set 2 : diff -r 45e3c28dc7b5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 45e3c28dc7b5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 221f3eb76b52 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	src/pkg/text/template/multi_test.go	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	src/pkg/text/template/template.go	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-11-24 15:53:32 UTC) #1

13 years, 3 months ago (2011-11-25 00:07:16 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=bcd30c187a37 ***

text/template: fix bug in Clone
Cloned template copied the root template incorrectly.
Add test of self-consistency.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5436063

Expand All Messages | Collapse All Messages