Issue 5436048: code review 5436048: html: on EOF in a comment, ignore final dashes (up to 2)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5436048: code review 5436048: html: on EOF in a comment, ignore final dashes (up to 2) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by andybalholm

Modified:
13 years, 3 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r a4eba56c7359 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a4eba56c7359 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/html/token.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-11-22 15:59:54 UTC) #1

nigeltao

LGTM. I'll add some trivial tests to token_test.go and submit.

13 years, 3 months ago (2011-11-22 22:25:59 UTC) #2

nigeltao

13 years, 3 months ago (2011-11-22 22:26:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b646abe0a2ee ***

html: on EOF in a comment, ignore final dashes (up to 2)

Pass tests2.dat, test 57:
<!DOCTYPE html><!--x--

| <!DOCTYPE html>
| <!-- x -->
| <html>
|   <head>
|   <body>

Also pass test 58:
<!DOCTYPE html><table><tr><td></p></table>

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5436048

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages