Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
LGTM On Thu, Nov 24, 2011 at 8:11 AM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: > Hello golang-dev@googlegroups.com, > > I'd like you to review this change to > https://go.googlecode.com/hg/ > > > Description: > effective_go: remove unused variable from a couple of examples > Fixes issue 2481. > > Please review this at http://codereview.appspot.com/**5435068/<http://codereview.appspot.com/5435068/> > > Affected files: > M doc/effective_go.html > M doc/effective_go.tmpl > > > Index: doc/effective_go.html > ==============================**==============================**======= > --- a/doc/effective_go.html > +++ b/doc/effective_go.html > @@ -2046,7 +2046,7 @@ > </p> > <pre> > func ArgServer() { > - for i, s := range os.Args { > + for _, s := range os.Args { > fmt.Println(s) > } > } > @@ -2084,7 +2084,7 @@ > <pre> > // Argument server. > func ArgServer(w http.ResponseWriter, req *http.Request) { > - for i, s := range os.Args { > + for _, s := range os.Args { > fmt.Fprintln(w, s) > } > } > Index: doc/effective_go.tmpl > ==============================**==============================**======= > --- a/doc/effective_go.tmpl > +++ b/doc/effective_go.tmpl > @@ -1984,7 +1984,7 @@ > </p> > <pre> > func ArgServer() { > - for i, s := range os.Args { > + for _, s := range os.Args { > fmt.Println(s) > } > } > @@ -2022,7 +2022,7 @@ > <pre> > // Argument server. > func ArgServer(w http.ResponseWriter, req *http.Request) { > - for i, s := range os.Args { > + for _, s := range os.Args { > fmt.Fprintln(w, s) > } > } > > >
*** Submitted as http://code.google.com/p/go/source/detail?r=221f3eb76b52 *** effective_go: remove unused variable from a couple of examples Fixes issue 2481. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5435068