code review 5432079: text/template: rename the method Template.Template to T...

text/template: rename the method Template.Template to Template.Lookup
Calling it Template makes it clumsy to embed the type, which html/template
depends on.

[r, 2011-11-25 18:42:15]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-11-25 20:28:40]

LGTM
- gri

On Fri, Nov 25, 2011 at 10:42 AM,  <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> text/template: rename the method Template.Template to Template.Lookup
> Calling it Template makes it clumsy to embed the type, which
> html/template
> depends on.
>
> Please review this at http://codereview.appspot.com/5432079/
>
> Affected files:
>  M src/pkg/text/template/exec_test.go
>  src/pkg/text/template/template.go
>
>
> Index: src/pkg/text/template/exec_test.go
> ===================================================================
> --- a/src/pkg/text/template/exec_test.go
> +++ b/src/pkg/text/template/exec_test.go
> @@ -677,7 +677,7 @@
>        }
>        const expect = "[1[2[3[4]][5[6]]][7[8[9]][10[11]]]]"
>        // First by looking up the template.
> -       err = tmpl.Template("tree").Execute(&b, tree)
> +       err = tmpl.Lookup("tree").Execute(&b, tree)
>        if err != nil {
>                t.Fatal("exec error:", err)
>        }
> Index: src/pkg/text/template/template.go
> ===================================================================
> --- a/src/pkg/text/template/template.go
> +++ b/src/pkg/text/template/template.go
> @@ -136,9 +136,9 @@
>        return t
>  }
>
> -// Template returns the template with the given name that is associated
> with t,
> +// Lookup returns the template with the given name that is associated with
> t,
>  // or nil if there is no such template.
> -func (t *Template) Template(name string) *Template {
> +func (t *Template) Lookup(name string) *Template {
>        return t.tmpl[name]
>  }
>
>
>
>

[r, 2011-11-26 16:33:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=23f64ced6a85 ***

text/template: rename the method Template.Template to Template.Lookup
Calling it Template makes it clumsy to embed the type, which html/template
depends on.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5432079