code review 5432071: os: fail if Open("") is called on windows

os: fail if Open("") is called on windows

[brainman, 2011-11-25 06:29:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-11-25 13:41:43]

LGTM
but what did it do before?
Add a test?
 On Nov 25, 2011 1:29 AM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> os: fail if Open("") is called on windows
>
> Please review this at
http://codereview.appspot.com/**5432071/<http://codereview.appspot.com/5432071/>
>
> Affected files:
>  M src/pkg/os/file_windows.go
>
>
> Index: src/pkg/os/file_windows.go
> ==============================**==============================**=======
> --- a/src/pkg/os/file_windows.go
> +++ b/src/pkg/os/file_windows.go
> @@ -89,6 +89,9 @@
>  // methods on the returned File can be used for I/O.
>  // It returns the File and an error, if any.
>  func OpenFile(name string, flag int, perm uint32) (file *File, err error)
> {
> +       if name == "" {
> +               return nil, &PathError{"open", name, syscall.ENOENT}
> +       }
>        // TODO(brainman): not sure about my logic of assuming it is dir
> first, then fall back to file
>        r, e := openDir(name)
>        if e == nil {
>
>
>

[brainman, 2011-11-26 00:01:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=503e62ea3467 ***

os: fail if Open("") is called on windows

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5432071