Issue 5432054: code review 5432054: go/printer, gofmt: 20 to 30% faster gofmt

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5432054: code review 5432054: go/printer, gofmt: 20 to 30% faster gofmt (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by gri

Modified:
13 years, 3 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go/printer, gofmt: 20 to 30% faster gofmt Buffer intermediate output via a bytes.Buffer and thus avoid calling through the entire Writer stack for every item printed. There is more opportunity for improvements along the same lines. Before (best of 3 runs): - printer.BenchmarkPrint 50 47959760 ns/op - time gofmt -l $GOROOT/src real 0m11.517s After (best of 3 runs): - printer.BenchmarkPrint 50 32056640 ns/op (= -33%) - time gofmt -l $GOROOT/src real 0m9.070s (= -21%)

Patch Set 1 #

Patch Set 2 : diff -r b646abe0a2ee https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b646abe0a2ee https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b646abe0a2ee https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b646abe0a2ee https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -80 lines)			Patch
	M	src/pkg/go/printer/nodes.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/go/printer/printer.go	View	1	13 chunks	+57 lines, -79 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-11-22 22:52:29 UTC) #1

gri

13 years, 3 months ago (2011-11-22 23:12:37 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=523db6d4d0ae ***

go/printer, gofmt: 20 to 30% faster gofmt

Buffer intermediate output via a bytes.Buffer and thus avoid
calling through the entire Writer stack for every item printed.
There is more opportunity for improvements along the same lines.

Before (best of 3 runs):
- printer.BenchmarkPrint	      50	  47959760 ns/op
- time gofmt -l $GOROOT/src	      real	  0m11.517s

After (best of 3 runs):
- printer.BenchmarkPrint	      50	  32056640 ns/op (= -33%)
- time gofmt -l $GOROOT/src	      real	  0m9.070s       (= -21%)

R=r
CC=golang-dev
http://codereview.appspot.com/5432054

Expand All Messages | Collapse All Messages