code review 5430059: go/ast: trivial cleanup (remove superfluous string conv...

go/ast: trivial cleanup (remove superfluous string conversion)

[gri, 2011-11-24 00:16:02]

Hello iant (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-11-24 00:18:52]

LGTM

On Wed, Nov 23, 2011 at 4:16 PM, <gri@golang.org> wrote:

> Reviewers: iant,
>
> Message:
> Hello iant (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> go/ast: trivial cleanup (remove superfluous string conversion)
>
> Please review this at
http://codereview.appspot.com/**5430059/<http://codereview.appspot.com/5430059/>
>
> Affected files:
>  M src/pkg/go/ast/resolve.go
>
>
> Index: src/pkg/go/ast/resolve.go
> ==============================**==============================**=======
> --- a/src/pkg/go/ast/resolve.go
> +++ b/src/pkg/go/ast/resolve.go
> @@ -113,7 +113,7 @@
>                                importErrors = true
>                                continue
>                        }
> -                       path, _ := strconv.Unquote(string(spec.**
> Path.Value))
> +                       path, _ := strconv.Unquote(spec.Path.**Value)
>                        pkg, err := importer(imports, path)
>                        if err != nil {
>                                p.errorf(spec.Path.Pos(), "could not import
> %s (%s)", path, err)
>
>
>

[gri, 2011-11-24 00:20:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=b0c70fdab574 ***

go/ast: trivial cleanup (remove superfluous string conversion)

R=iant, bradfitz
CC=golang-dev
http://codereview.appspot.com/5430059