code review 5417059: encoding/xml: fix copy bug

encoding/xml: fix copy bug

Fixes issue 2484.

[rsc, 2011-11-21 20:38:18]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-11-21 20:43:29]

LGTM

On Mon, Nov 21, 2011 at 3:38 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> encoding/xml: fix copy bug
>
> Fixes issue 2484.
>
> Please review this at
http://codereview.appspot.com/**5417059/<http://codereview.appspot.com/5417059/>
>
> Affected files:
>  M src/pkg/encoding/xml/xml.go
>  M src/pkg/encoding/xml/xml_test.**go
>
>
> Index: src/pkg/encoding/xml/xml.go
> ==============================**==============================**=======
> --- a/src/pkg/encoding/xml/xml.go
> +++ b/src/pkg/encoding/xml/xml.go
> @@ -61,7 +61,7 @@
>
>  func (e StartElement) Copy() StartElement {
>        attrs := make([]Attr, len(e.Attr))
> -       copy(e.Attr, attrs)
> +       copy(attrs, e.Attr)
>        e.Attr = attrs
>        return e
>  }
> Index: src/pkg/encoding/xml/xml_test.**go
> ==============================**==============================**=======
> --- a/src/pkg/encoding/xml/xml_**test.go
> +++ b/src/pkg/encoding/xml/xml_**test.go
> @@ -488,10 +488,13 @@
>        elt := StartElement{Name{"", "hello"}, []Attr{{Name{"", "lang"},
> "en"}}}
>        var tok1 Token = elt
>        tok2 := CopyToken(tok1)
> +       if tok1.(StartElement).Attr[0].**Value != "en" {
> +               t.Error("CopyToken overwrote Attr[0]")
> +       }
>        if !reflect.DeepEqual(tok1, tok2) {
>                t.Error("CopyToken(**StartElement) != StartElement")
>        }
> -       elt.Attr[0] = Attr{Name{"", "lang"}, "de"}
> +       tok1.(StartElement).Attr[0] = Attr{Name{"", "lang"}, "de"}
>        if reflect.DeepEqual(tok1, tok2) {
>                t.Error("CopyToken(CharData) uses same buffer.")
>        }
>
>
>

[rsc, 2011-11-22 17:31:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=f2192a3014e8 ***

encoding/xml: fix copy bug

Fixes issue 2484.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5417059