Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(520)

Issue 54160043: code review 54160043: runtime: if "panic during panic"'s stacktrace fails, do... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by khr
Modified:
11 years, 1 month ago
Reviewers:
iant
CC:
golang-codereviews, iant, khr1, dvyukov
Visibility:
Public.

Description

runtime: if "panic during panic"'s stacktrace fails, don't recurse.

Patch Set 1 #

Patch Set 2 : diff -r 5b5a2d2d2563 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 5b5a2d2d2563 https://khr%40golang.org@code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 5b5a2d2d2563 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 5b5a2d2d2563 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 6 : diff -r 5b5a2d2d2563 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 7 : diff -r 5b5a2d2d2563 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 8 : diff -r c057b92310eb https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 9 : diff -r b57b768b42f9 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M src/pkg/runtime/panic.c View 1 2 3 4 5 6 7 1 chunk +25 lines, -10 lines 0 comments Download

Messages

Total messages: 8
khr
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
11 years, 1 month ago (2014-01-18 21:48:27 UTC) #1
iant
https://codereview.appspot.com/54160043/diff/40001/src/pkg/runtime/panic.c File src/pkg/runtime/panic.c (right): https://codereview.appspot.com/54160043/diff/40001/src/pkg/runtime/panic.c#newcode374 src/pkg/runtime/panic.c:374: runtime·printf("panic during panic\n"); Seems to me you need to ...
11 years, 1 month ago (2014-01-19 05:11:43 UTC) #2
khr1
Good point, fixed. PTAL. On Sat, Jan 18, 2014 at 9:11 PM, <iant@golang.org> wrote: > ...
11 years, 1 month ago (2014-01-19 07:25:58 UTC) #3
dvyukov
On 2014/01/19 07:25:58, khr1 wrote: You seem forgot to upload, it still contains "m->dying = ...
11 years, 1 month ago (2014-01-19 07:43:13 UTC) #4
iant
On Sat, Jan 18, 2014 at 11:43 PM, <dvyukov@google.com> wrote: > On 2014/01/19 07:25:58, khr1 ...
11 years, 1 month ago (2014-01-20 19:24:22 UTC) #5
khr
On 2014/01/20 19:24:22, iant wrote: > On Sat, Jan 18, 2014 at 11:43 PM, <mailto:dvyukov@google.com> ...
11 years, 1 month ago (2014-01-21 21:52:41 UTC) #6
iant
LGTM
11 years, 1 month ago (2014-01-21 22:13:31 UTC) #7
khr
11 years, 1 month ago (2014-01-21 22:34:39 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=e8977a85a0e8 ***

runtime: if "panic during panic"'s stacktrace fails, don't recurse.

R=golang-codereviews, iant, khr, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/54160043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b