Issue 5399051: code review 5399051: gotour: fix misleading hint (currently suggests divide ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5399051: code review 5399051: gotour: fix misleading hint (currently suggests divide ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by adg

Modified:
12 years, 6 months ago

Reviewers:
rsc

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

gotour: fix misleading hint (currently suggests divide by zero) Fixees issue 15.

Patch Set 1 #

Patch Set 2 : diff -r 316215eb8cc8 https://go-tour.googlecode.com/hg #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	static/index.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go-tour.googlecode.com/hg

12 years, 6 months ago (2011-11-17 03:54:33 UTC) #1

adg

*** Submitted as http://code.google.com/p/go-tour/source/detail?r=c80b0cb63992 *** gotour: fix misleading hint (currently suggests divide by zero) Fixees ...

12 years, 6 months ago (2011-11-17 04:13:26 UTC) #3

rsc

12 years, 6 months ago (2011-11-17 06:58:37 UTC) #4

s/float64(1.0)/float64(1)/.
there's no point to the conversion with the .0.

Expand All Messages | Collapse All Messages