code review 5393049: text/template: refactor set parsing

text/template: refactor set parsing
Parse {{define}} blocks during template parsing rather than separately as a set-specific thing.
This cleans up set parse significantly, and enables the next step, if we want, to unify the
API for templates and sets.
Other than an argument change to parse.Parse, which is in effect an internal function and
unused by client code, there is no API change and no spec change yet.

[r, 2011-11-17 00:04:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-17 21:52:42]

On Thu, Nov 17, 2011 at 13:32,  <gri@golang.org> wrote:
> I seem to be unable to use Rietveld this morning (getting "Error:
> CapabilityDisabledError; please report!" errors, and I am properly
> signed in) when trying to add a comment in-line.

see the big yellow banner at the top of every page.  :-)

[r2, 2011-11-17 22:21:33]

On Nov 17, 2011, at 10:32 AM, gri@golang.org wrote:

> I seem to be unable to use Rietveld this morning (getting "Error:
> CapabilityDisabledError; please report!" errors, and I am properly
> signed in) when trying to add a comment in-line.
> 
> LGTM
> 
> parse.go:
> 159
>    there's no 'nested' anywhere in this file


oops, hangover from a previous attempt. fixed.

-rob

[r, 2011-11-18 06:53:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=aaa96dbb57e4 ***

text/template: refactor set parsing
Parse {{define}} blocks during template parsing rather than separately as a
set-specific thing.
This cleans up set parse significantly, and enables the next step, if we want,
to unify the
API for templates and sets.
Other than an argument change to parse.Parse, which is in effect an internal
function and
unused by client code, there is no API change and no spec change yet.

R=golang-dev, rsc, r
CC=golang-dev
http://codereview.appspot.com/5393049