Issue 53810043: code review 53810043: net/http, net/http/httputil: make chunked reader alloc ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 53810043: code review 53810043: net/http, net/http/httputil: make chunked reader alloc ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by bradfitz

Modified:
10 years, 4 months ago

Reviewers:
brainman

CC:
golang-codereviews, brainman

Visibility:
Public.

Description

net/http, net/http/httputil: make chunked reader alloc test more robust Use testing.AllocsPerRun now that it exists, instead of doing it by hand. Fixes Issue 6076

Patch Set 1 #

Patch Set 2 : diff -r ffdf8fdd1e5a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ffdf8fdd1e5a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 127cdfa124b9 https://go.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -44 lines)			Patch
		src/pkg/net/http/chunked_test.go	View	1	3 chunks	+17 lines, -22 lines	0 comments	Download
		src/pkg/net/http/httputil/chunked_test.go	View	1	3 chunks	+17 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 4 months ago (2014-01-17 19:11:32 UTC) #1

bradfitz

10 years, 4 months ago (2014-01-19 18:02:14 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2df447356d7f ***

net/http, net/http/httputil: make chunked reader alloc test more robust

Use testing.AllocsPerRun now that it exists, instead of doing it by hand.

Fixes Issue 6076

R=golang-codereviews, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/53810043

Expand All Messages | Collapse All Messages