Issue 5376076: code review 5376076: gc: remove m[k] = x, false

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5376076: code review 5376076: gc: remove m[k] = x, false (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: remove m[k] = x, false

Patch Set 1 #

Patch Set 2 : diff -r 94e51b48f088 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 5a1c75805f59 https://go.googlecode.com/hg #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -71 lines)			Patch
M	src/cmd/gc/esc.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/gc/fmt.c	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	2 chunks	+2 lines, -11 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1	2 chunks	+0 lines, -12 lines	0 comments	Download
M	src/pkg/runtime/hashmap.c	View	1	1 chunk	+0 lines, -28 lines	0 comments	Download
R	test/fixedbugs/bug220.go	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
M	test/fixedbugs/bug242.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/named1.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 4 months ago (2011-11-11 21:48:24 UTC) #1

rsc

13 years, 4 months ago (2011-11-11 21:48:28 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=daa23bc3b7c5 ***

gc: remove m[k] = x, false

R=ken2
CC=golang-dev
http://codereview.appspot.com/5376076

Expand All Messages | Collapse All Messages