Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(904)

Issue 5376066: code review 5376066: exp/terminal: rename shell to terminal and add SetSize (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by agl1
Modified:
13 years, 4 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

exp/terminal: rename shell to terminal and add SetSize It was never really a shell, but the name carried over from SSH's ServerShell. Two small functional changes: Add SetSize, which allows the size of the terminal to be changed in response, say, to an SSH message. Don't write the prompt if there's already something on the current line.

Patch Set 1 #

Patch Set 2 : diff -r c553b0cbb873 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c553b0cbb873 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f0c16390bfab https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -110 lines) Patch
M src/pkg/exp/terminal/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/terminal/terminal.go View 1 7 chunks +113 lines, -107 lines 0 comments Download
M src/pkg/exp/terminal/terminal_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-11 16:23:45 UTC) #1
rsc
LGTM Maybe eventually the package should be named vt100. Not now though.
13 years, 4 months ago (2011-11-11 18:03:59 UTC) #2
agl1
13 years, 4 months ago (2011-11-11 19:04:32 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=0c0f211fbacf ***

exp/terminal: rename shell to terminal and add SetSize

It was never really a shell, but the name carried
over from SSH's ServerShell.

Two small functional changes:

Add SetSize, which allows the size of the terminal
to be changed in response, say, to an SSH message.

Don't write the prompt if there's already something
on the current line.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5376066
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b