code review 5375042: cgo: add support for callbacks from dynamic libraries

cgo: add support for callbacks from dynamic libraries

[dvyukov, 2011-11-09 17:17:56]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
mpimenov@google.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-09 18:18:34]

Could you please add a test?
It is very hard for me to see what this is doing,
and I am sure to break it in the future without a test.

Thanks.
Russ

[dvyukov, 2011-11-10 16:08:11]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com, mpimenov@google.com),

Please take another look.

[dvyukov, 2011-11-10 16:11:46]

On 2011/11/09 18:18:34, rsc wrote:
> Could you please add a test?
> It is very hard for me to see what this is doing,
> and I am sure to break it in the future without a test.

Done.
It works on Linux. Unfortunately I was unable to make it work on Darwin, the
problem seems to be with how 6l generates Macho headers, the executable seems to
miss some commands/sections/symbol flags or something. I am not sure about
Free/OpenBSD, ideally they just work, if not we may disable them as well.

[dvyukov, 2011-11-14 18:55:01]

ping

On 2011/11/10 16:11:46, dvyukov wrote:
> On 2011/11/09 18:18:34, rsc wrote:
> > Could you please add a test?
> > It is very hard for me to see what this is doing,

we need cgo callbacks work from dynamic libraries

> > and I am sure to break it in the future without a test.
> 
> Done.
> It works on Linux. Unfortunately I was unable to make it work on Darwin, the
> problem seems to be with how 6l generates Macho headers, the executable seems
to
> miss some commands/sections/symbol flags or something. I am not sure about
> Free/OpenBSD, ideally they just work, if not we may disable them as well.

[rsc, 2011-11-16 21:20:34]

LGTM

[dvyukov, 2011-11-22 14:58:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=a4eba56c7359 ***

cgo: add support for callbacks from dynamic libraries

R=golang-dev, rsc
CC=golang-dev, mpimenov
http://codereview.appspot.com/5375042