code review 5374046: effective_go: fix up the description of cipher blocks a...

effective_go: fix up the description of cipher blocks and streams

[r, 2011-11-09 22:20:43]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r2, 2011-11-09 22:22:25]

i have no idea if this is a correct explanation; i just followed some type
declarations and tried to explain what appears to be going on. please correct as
necessary. i am not a crypto expert. i am not even a crypto newbie.

-rob

[agl1, 2011-11-09 22:31:46]

LGTM

http://codereview.appspot.com/5374046/diff/1/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/5374046/diff/1/doc/effective_go.html#newcode1961
doc/effective_go.html:1961: encryption with other encryptions is a localized
change.  The constructor
s/encryptions/encryption modes/

http://codereview.appspot.com/5374046/diff/1/doc/effective_go.tmpl
File doc/effective_go.tmpl (right):

http://codereview.appspot.com/5374046/diff/1/doc/effective_go.tmpl#newcode1899
doc/effective_go.tmpl:1899: encryption with other encryptions is a localized
change.  The constructor
ditto

[dsymonds, 2011-11-09 22:33:02]

http://codereview.appspot.com/5374046/diff/1/doc/effective_go.tmpl
File doc/effective_go.tmpl (right):

http://codereview.appspot.com/5374046/diff/1/doc/effective_go.tmpl#newcode1860
doc/effective_go.tmpl:1860: behavior of the cryptographic elements.
perhaps
  specifies the behavior of a block cipher.
or, if you want something more verbose
  specifies the behavior of a block cipher, which provides encryption of an
individual block.

http://codereview.appspot.com/5374046/diff/1/doc/effective_go.tmpl#newcode1899
doc/effective_go.tmpl:1899: encryption with other encryptions is a localized
change.  The constructor
... replacing the CTR cipher mode with other cipher modes is a localized change.

[r, 2011-11-09 22:36:42]

Hello golang-dev@googlegroups.com, r@google.com, agl@golang.org,
dsymonds@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[agl1, 2011-11-09 22:38:40]

LGTM

[r, 2011-11-09 22:40:54]

*** Submitted as http://code.google.com/p/go/source/detail?r=cf4409a42d20 ***

effective_go: fix up the description of cipher blocks and streams

R=golang-dev, r, agl, dsymonds
CC=golang-dev
http://codereview.appspot.com/5374046