Issue 5373077: code review 5373077: build: fix check for selinux's allow_execstack on Fedora 16

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5373077: code review 5373077: build: fix check for selinux's allow_execstack on Fedora 16

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by bpowers

Modified:
12 years, 5 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

build: fix check for selinux's allow_execstack on Fedora 16 Fedora 16 mounts selinux at /sys/fs/selinux, instead of the traditional /selinux. Check both locations for the selinux filesystem in make.bash Fixes issue 2448.

Patch Set 1 #

Patch Set 2 : diff -r 94e51b48f088 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 94e51b48f088 https://go.googlecode.com/hg/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -13 lines)			Patch
	M	src/make.bash	View	1	1 chunk	+18 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bpowers

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 5 months ago (2011-11-11 21:39:56 UTC) #1

rsc

12 years, 5 months ago (2011-11-11 21:41:41 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5a1c75805f59 ***

build: fix check for selinux's allow_execstack on Fedora 16

Fedora 16 mounts selinux at /sys/fs/selinux, instead of the
traditional /selinux.  Check both locations for the selinux
filesystem in make.bash

Fixes issue 2448.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5373077

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages