Issue 5372091: code review 5372091: crypto/openpgp/packet: fix private key checksum

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5372091: code review 5372091: crypto/openpgp/packet: fix private key checksum (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by agl1

Modified:
13 years, 3 months ago

Reviewers:

CC:
bradfitz, r, rsc, golang-dev

Visibility:
Public.

Description

crypto/openpgp/packet: fix private key checksum I misinterpreted http://tools.ietf.org/html/rfc4880#section-5.5.3 and implemented the sum of 16-bit values, rather than the 16-bit sum of 8-bit values. Thanks to Szabolcs Nagy for pointing it out.

Patch Set 1 #

Patch Set 2 : diff -r 01baaa1a6b5a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 01baaa1a6b5a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a5185f942ad9 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a5185f942ad9 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	src/pkg/crypto/openpgp/packet/private_key.go	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-13 17:40:22 UTC) #1

agl1

13 years, 3 months ago (2011-11-23 14:44:36 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c2271db8aac1 ***

crypto/openpgp/packet: fix private key checksum

I misinterpreted http://tools.ietf.org/html/rfc4880#section-5.5.3
and implemented the sum of 16-bit values, rather than the 16-bit sum
of 8-bit values.

Thanks to Szabolcs Nagy for pointing it out.

R=bradfitz, r, rsc
CC=golang-dev
http://codereview.appspot.com/5372091

Expand All Messages | Collapse All Messages