Issue 5371087: code review 5371087: syscall: fix linux arm build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5371087: code review 5371087: syscall: fix linux arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

syscall: fix linux arm build Regenerate system call file.

Patch Set 1 #

Patch Set 2 : diff -r 3e61d28018a1 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 3e61d28018a1 https://go.googlecode.com/hg #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+496 lines, -248 lines)			Patch
	M	src/pkg/syscall/zsyscall_linux_arm.go	View	1	22 chunks	+496 lines, -248 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 4 months ago (2011-11-14 06:23:26 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=4b5c859153bb *** syscall: fix linux arm build Regenerate system call file. TBR=bradfitz ...

13 years, 4 months ago (2011-11-14 06:23:29 UTC) #2

bradfitz

13 years, 4 months ago (2011-11-14 16:37:15 UTC) #3

LGTM


On Sun, Nov 13, 2011 at 10:23 PM, <rsc@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> syscall: fix linux arm build
>
> Regenerate system call file.
>
> Please review this at
http://codereview.appspot.com/**5371087/<http://codereview.appspot.com/5371087/>
>
> Affected files:
>  M src/pkg/syscall/zsyscall_**linux_arm.go
>
>
>

Expand All Messages | Collapse All Messages