code review 5370058: tutorial: describe unidirectional channels

tutorial: describe unidirectional channels

[r, 2011-11-10 21:20:44]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-11-10 21:26:45]

http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.tmpl
File doc/go_tutorial.tmpl (right):

http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.tmpl#newcode977
doc/go_tutorial.tmpl:977: The arrow points in a mnemonic direction to indicate
whether data flows into or out of
the direction is mnemonic? seems plausible, but made me a double-take

http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.tmpl#newcode994
doc/go_tutorial.tmpl:994: them, such as in function signatures, you will be less
likely to use the
less likely? You just can't.

http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.tmpl#newcode996
doc/go_tutorial.tmpl:996: Note that it's pointless to <code>make</code>
single-direction channels, since you can't
Not sure if this is worth mentioning. Guess it doesn't cost anything.

[r2, 2011-11-10 21:29:46]

On Nov 10, 2011, at 1:26 PM, adg@golang.org wrote:

> 
> http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.tmpl
> File doc/go_tutorial.tmpl (right):
> 
> http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.tmpl#newcode977
> doc/go_tutorial.tmpl:977: The arrow points in a mnemonic direction to
> indicate whether data flows into or out of
> the direction is mnemonic? seems plausible, but made me a double-take

yes, it's a memory aid.

> http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.tmpl#newcode994
> doc/go_tutorial.tmpl:994: them, such as in function signatures, you will
> be less likely to use the
> less likely? You just can't.

you might screw up elsewhere.

> http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.tmpl#newcode996
> doc/go_tutorial.tmpl:996: Note that it's pointless to <code>make</code>
> single-direction channels, since you can't
> Not sure if this is worth mentioning. Guess it doesn't cost anything.

trying to forestall the obvious question.

-rob

[r, 2011-11-10 21:29:46]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[gri, 2011-11-10 21:29:51]

LGTM

http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.html
File doc/go_tutorial.html (right):

http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.html#newcode1392
doc/go_tutorial.html:1392: indicate that the channel can be used only one way:
<code>&lt;-chan</code> means "receive only",
... that the channel can only be used for receiving (<-chan) or sending data
(chan<-). The arrow points ...

(perhaps simpler)

http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.html#newcode1415
doc/go_tutorial.html:1415: Bidirectional channels can be assigned to
single-direction channels but not the
s/single-directional/unidirectional/ ?

http://codereview.appspot.com/5370058/diff/1/doc/go_tutorial.html#newcode1419
doc/go_tutorial.html:1419: Note that it's pointless to <code>make</code>
single-direction channels, since you can't
s/single-directional/unidirectional/ ?

[r, 2011-11-10 21:58:06]

Hello golang-dev@googlegroups.com, adg@golang.org, gri@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[gri, 2011-11-10 22:00:33]

LGTM

[r, 2011-11-10 22:02:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=bf9901c10e5e ***

tutorial: describe unidirectional channels

R=golang-dev, adg, gri
CC=golang-dev
http://codereview.appspot.com/5370058

[adg, 2011-11-11 02:50:35]

LGTM