Issue 5370049: code review 5370049: effective_go: a little more about comma ok and type ass...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5370049: code review 5370049: effective_go: a little more about comma ok and type ass... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by r

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

effective_go: a little more about comma ok and type assertion Fixes issue 2416.

Patch Set 2 : diff -r 62b5ae00a9b0 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	doc/effective_go.html	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
	M	doc/effective_go.tmpl	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-09 22:54:20 UTC) #1

iant

LGTM http://codereview.appspot.com/5370049/diff/1/doc/effective_go.tmpl File doc/effective_go.tmpl (right): http://codereview.appspot.com/5370049/diff/1/doc/effective_go.tmpl#newcode2665 doc/effective_go.tmpl:2665: If the type assertion fails, <code>ok</code> will be ...

13 years, 4 months ago (2011-11-10 00:10:45 UTC) #2

13 years, 4 months ago (2011-11-10 00:14:22 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=056504e48dd3 ***

effective_go: a little more about comma ok and type assertion
Fixes issue 2416.

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/5370049

Expand All Messages | Collapse All Messages