code review 5369092: syscall: add SUSv3 RLIMIT/RUSAGE constants

syscall: add SUSv3 RLIMIT/RUSAGE constants

[Sebastien Paolacci, 2011-11-14 09:30:00]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[mikio, 2011-11-16 02:25:23]

Hi,

On Mon, Nov 14, 2011 at 6:30 PM,  <sebastien.paolacci@gmail.com> wrote:

> Description:
> syscall: add SUSv3 RLIMIT/RUSAGE constants

Can you please proceed license agreement procedure?
<http://golang.org/doc/contribute.html#copyright>

> Affected files:
>  M src/pkg/syscall/mkerrors.sh
>  M src/pkg/syscall/zerrors_linux_amd64.go
>  M src/pkg/syscall/zsysnum_linux_amd64.go
>  M src/pkg/syscall/ztypes_linux_amd64.go

Well, what about the rest of us?

SUSv3 full/semi-compliant families would be:
- darwin/386, amd64
- freebsd/386, amd64
- openbsd/386, amd64 (Thank you Joel Sing for the upcoming cgo -godefs
on 386 fix ;)
- linux/386, arm

[rsc, 2011-11-16 22:04:26]

On Tue, Nov 15, 2011 at 21:25, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> Well, what about the rest of us?

as long as no code is being added that
depends on these constants, the build
won't break.  it's okay to add just the
systems you have access to and then
we'll catch the others next time we generate
the files.

[Sebastien Paolacci, 2011-11-17 13:33:47]

That's what I though. I may however get hands on a freebsd box later today so
I'll push that one too, as well as corresponding 386 variants.

[Sebastien Paolacci, 2011-11-18 12:45:55]

Hello golang-dev@googlegroups.com, mikioh.mikioh@gmail.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-11-19 04:50:57]

LGTM

[mikio, 2011-11-19 06:17:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=fe7ee6bb723f ***

syscall: add SUSv3 RLIMIT/RUSAGE constants

R=golang-dev, mikioh.mikioh, rsc
CC=golang-dev
http://codereview.appspot.com/5369092

Committer: Mikio Hara <mikioh.mikioh@gmail.com>