Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 5342041: code review 5342041: http: clarify Request docs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by bradfitz
Modified:
13 years, 4 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

http: clarify Request docs

Patch Set 1 #

Patch Set 2 : diff -r 37533e1cfe43 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 37533e1cfe43 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 37533e1cfe43 https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 5 : diff -r 37533e1cfe43 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M src/pkg/net/http/request.go View 1 2 3 4 5 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-04 01:19:04 UTC) #1
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 4 months ago (2011-11-04 02:37:24 UTC) #2
rsc
LGTM http://codereview.appspot.com/5342041/diff/7001/src/pkg/net/http/request.go File src/pkg/net/http/request.go (right): http://codereview.appspot.com/5342041/diff/7001/src/pkg/net/http/request.go#newcode133 src/pkg/net/http/request.go:133: // Only available after ParseForm is called. // ...
13 years, 4 months ago (2011-11-04 02:46:53 UTC) #3
bradfitz
http://codereview.appspot.com/5342041/diff/7001/src/pkg/net/http/request.go File src/pkg/net/http/request.go (right): http://codereview.appspot.com/5342041/diff/7001/src/pkg/net/http/request.go#newcode133 src/pkg/net/http/request.go:133: // Only available after ParseForm is called. On 2011/11/04 ...
13 years, 4 months ago (2011-11-04 03:04:30 UTC) #4
bradfitz
13 years, 4 months ago (2011-11-04 03:05:16 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=e93d0d1f82f3 ***

http: clarify Request docs

R=rsc
CC=golang-dev
http://codereview.appspot.com/5342041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b